Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable m3u8 playback #1560

Closed
wants to merge 2 commits into from

Conversation

fishcakeday
Copy link
Contributor

Fix for #798 with additional fixes for audio track detection and video size setting, so it works with HLS, as well as other video files.

@fishcakeday
Copy link
Contributor Author

Copy link
Contributor

@bryanmontz bryanmontz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall. Could you add some screenshots or gifs of this in action to the PR description or in a comment?

damus/Views/Video/DamusVideoPlayer.swift Outdated Show resolved Hide resolved
damus/Views/Video/DamusVideoPlayer.swift Outdated Show resolved Hide resolved
damus/Views/Video/DamusVideoPlayerViewModel.swift Outdated Show resolved Hide resolved
damus/Views/Video/DamusVideoPlayerViewModel.swift Outdated Show resolved Hide resolved
damus/Views/Video/DamusVideoPlayerViewModel.swift Outdated Show resolved Hide resolved
damus/Views/Video/DamusVideoPlayerViewModel.swift Outdated Show resolved Hide resolved
damus/Views/Video/DamusVideoPlayerViewModel.swift Outdated Show resolved Hide resolved
@jb55
Copy link
Collaborator

jb55 commented Sep 29, 2023 via email

@fishcakeday
Copy link
Contributor Author

Here are sample videos demonstrating HLS stream playback, both VoD and LIVE.
https://v.nostr.build/PkJ5.mp4
https://v.nostr.build/zgW8.mp4

jb55 pushed a commit that referenced this pull request Oct 1, 2023
Closes: #1560
Signed-off-by: William Casarin <[email protected]>
jb55 pushed a commit that referenced this pull request Oct 1, 2023
… add live stream indicator

Closes: #1560
Signed-off-by: William Casarin <[email protected]>
@jb55 jb55 closed this in d6c7240 Oct 4, 2023
jb55 pushed a commit that referenced this pull request Oct 4, 2023
… add live stream indicator

Closes: #1560
Signed-off-by: William Casarin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants