Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Github Action to publish the images #280

Merged
merged 1 commit into from
May 17, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
File renamed without changes.
21 changes: 8 additions & 13 deletions .github/workflows/docker_hub.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@ name: Publish Docker images

on:
workflow_dispatch: # manually triggered
# push:
# branches: [ latest, stable ]
push:
branches: [ latest, stable, 24.05 ]

jobs:
push_to_registry:
Expand Down Expand Up @@ -35,21 +35,16 @@ jobs:
uses: docker/build-push-action@v2
with:
context: .
file: buster/Dockerfile
file: Dockerfile
push: true
tags: |
dalibo/pandocker:${{ steps.branch.outputs.branch_name }}
dalibo/pandocker:${{ steps.branch.outputs.branch_name }}-buster
dalibo/pandocker:${{ steps.branch.outputs.branch_name }}-buster-extra
target: extra
tags: dalibo/pandocker:${{ steps.branch.outputs.branch_name }}

- name: Build and push the `full` image
uses: docker/build-push-action@v2
with:
context: .
file: buster-full/Dockerfile
file: Dockerfile
push: true
# The tag `xxx-full` is not officially supported, only kept for backward compat
tags: |
dalibo/pandocker:${{ steps.branch.outputs.branch_name }}-buster-full
dalibo/pandocker:${{ steps.branch.outputs.branch_name }}-full

target: full
tags: dalibo/pandocker:${{ steps.branch.outputs.branch_name }}-full
10 changes: 7 additions & 3 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -46,15 +46,19 @@ in the repository for archiving purposes in the public interest.
How To Release a new version
-------------------------------------------------------------------------------

Let's say you want to release version `23.07`

* [ ] Close all open ticket on the current milestone
* [ ] Create a `release` branch
* [ ] Update the [CHANGELOG.md]()
* [ ] Add `23.07` in `on.push.branches` in [.github/workflows/docker_hub.yml]()
* [ ] Write a announcement in [NEWS.md]()
* [ ] Merge the `release` branch into `latest`
* [ ] Add a tag to `latest`
* [ ] Add a tag `23.07` to `latest`
* [ ] Create a new [release]
* [ ] Rebase the `stable` branche from `latest`
* [ ] Wait for docker hub to rebuild the images
* [ ] Rebase the `stable` branch from `latest`
* [ ] Create a `23.07` branch from `latest`
* [ ] Check that github Actions is correctly publishing the images
* [ ] Create the next milestone
* [ ] Bump the new version on `latest`
* [ ] Publish the announcement
Expand Down
23 changes: 9 additions & 14 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -152,24 +152,19 @@ The full variant includes

## Supported Tags : Branch + Variant + Parent

The image is available in multiple versions named as follows:
The image is available in 4 versions named as follows:

`branch[-parent[-variant]]`
* `latest` (default): minimal image containing the most recent changes
* `stable` : minimal image based on the latest stable release
* `latest-full` (default): complete image containing the most recent changes
* `stable-full` : complete image based on the latest stable release

* The __branch__ can be `latest` (default) or `stable` (for production)
or the release name (`20.02`)
* The __parent__ is the base image we are using. Currently only `ubuntu`
is supported
* The __variant__ is either `extra` (330MB) or `full` (810 MB)
You can also the release names for instance

The supported tags are :
`docker pull dalibo/pandocker:24.05`

* `latest`, `latest-ubuntu`, `latest-ubuntu-extra` (default)
* `latest-ubuntu-full`
* `stable`, `stable-ubuntu`, `stable-ubuntu-extra`
* `stable-ubuntu-full`

Other tags are not supported and should be used with care.
the previous versions add more complex tags such as `latest-ubuntu-extra`
or `stable-buster`. They are not supported anymore.

## Build it

Expand Down
Loading