Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ui] A few tick timeline bugfixes #26137

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hellendag
Copy link
Member

@hellendag hellendag commented Nov 25, 2024

Summary & Motivation

A handful of bugfixes on the sensor tick timeline.

  • When paginating to older ticks, the "Now" line renders offscreen on the timeline, making the entire page h-scrollable. Now, the "Now" line only renders when it is in range.
  • In some circumstances, the timestamp labels do not render on the timeline on "older" pages. Fix this.
  • Show the timestamp in the hover tooltip on ticks in the timeline, to provide a bit more context to the user.

Missing time label example:

Before:

Screenshot 2024-11-25 at 12 35 13

After:

Screenshot 2024-11-25 at 12 32 18

Hover state on tick:

Screenshot 2024-11-25 at 12 32 09

How I Tested These Changes

View sensors in elementl, verify that the tick timeline renders and behaves as described above.

Changelog

[ui] Fixed timestamp labels and "Now" line rendering bugs on the sensor tick timeline.

Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@hellendag hellendag marked this pull request as ready for review November 25, 2024 18:37
Copy link

Deploy preview for dagit-core-storybook ready!

✅ Preview
https://dagit-core-storybook-n3girp0sg-elementl.vercel.app
https://dish-fe-700-sensor-tick-timeline-breaks-window-horizontally.core-storybook.dagster-docs.io

Built with commit 8b5c873.
This pull request is being automatically deployed with vercel-action

Copy link
Collaborator

@bengotow bengotow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great - I actually didn't realize that paginating on this page also stepped you back in the tick timeline :-o I thought it was always the last X minutes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants