[ui] Fix tags on backfill table #26126
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hellendag
force-pushed
the
dish/fe-694-fix-padding-issues-in-in-progress-and-succeeded-ovals
branch
from
c0af233
to
898456f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Fix stretched tags on Backfill table.
The row cells are flex column containers with no
alignItemsvalue set, so the children stretch, causingTagelements to occupy the entire cell width.It's not really safe to change
RowCellto havealign-items: flex-startsince that would have broader/riskier impact on other table views, so the simple thing to do here is just wrap theTagelements indivs.How I Tested These Changes
View a backfill table with tags, verify that they no longer stretch.
Changelog
[ui] Fix stretched tags in backfill table view for non-partitioned assets.