Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ui] FIx backfill partition range coloring, clarify meaning of progress bars #26123

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bengotow
Copy link
Collaborator

@bengotow bengotow commented Nov 25, 2024

Summary & Motivation

Related: https://linear.app/dagster-labs/issue/FE-689/backfill-ui-partition-range-display-issue

This is a handful of small fixes for the backfill partitions pages:

  • These tags were rendering full-width, and the terminology (succeeded vs completed) was inconsistent. Clicking it takes you to a view of Succeeded runs, so I changed both to succeeded:
    image

  • On this page, the two gray colors used in the bars were very similar, which was confusing - now using backgroundDisabled():

image
  • When viewing a backfill, there is a color bar that is not related to the color bars above - it indicates the success or failure of the subset of partitions you chose to backfill. This can be sorta confusing (why does this bar not have the gray bands from the previous screenshot?). I added a small caption: "100% complete" that clarifies that this bar relates to the backfill, not the partition set:
image
  • The centering of these two items looked odd - aligned them to the top text baseline:
image
  • Dates from previous years were wrapping in the new Runs Feed table - needed slightly more space:
image

How I Tested These Changes

I tested these changes manually using both op and asset backfills!

Copy link

github-actions bot commented Nov 25, 2024

Deploy preview for dagit-core-storybook ready!

✅ Preview
https://dagit-core-storybook-e5tibtybb-elementl.vercel.app
https://bengotow-2024-11-FE-689.core-storybook.dagster-docs.io

Built with commit 4afe744.
This pull request is being automatically deployed with vercel-action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant