Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spanner kind icon #26072

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

AdamSkarboJonsson
Copy link

@AdamSkarboJonsson AdamSkarboJonsson commented Nov 21, 2024

Summary & Motivation

I'm using Dagster and Spanner so I'd like to add the Spanner kind to all Spanner-related assets for a cleaner UI.
I downloaded the .svg from https://cloud.google.com/icons?hl=en.

How I Tested These Changes

Followed #25781 exactly:

Regenerated the kind tags, ran the Dagster documentation website locally and verified that the kind was visible in the overview.

image

Changelog

[ui] Add Spanner kind icon

@salazarm
Copy link
Contributor

Can you follow #25839 instead.
The PR you followed caused the build to fail the same way yours is failing right now.

Copy link
Contributor

@salazarm salazarm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comment

@AdamSkarboJonsson
Copy link
Author

AdamSkarboJonsson commented Nov 22, 2024

The build step ran time cd docs && time make next-dev-install && time make mdx-format && time git diff --exit-code and failed. It doesn't fail when I run it locally with the new commit. So a new build should succeed :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants