pass through retry_policy for dbt assets #22143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rexledesma
reviewed
May 29, 2024
There was a problem hiding this comment.
There was a previous PR that tried adding this and I pushed back: #18990
|
We may still want to add this, so that users can specify delay/jitter in retrying a dbt job due to some resource constraint. This may be coarse-grained compared to |
rexledesma
approved these changes
May 30, 2024
python_modules/libraries/dagster-dbt/dagster_dbt_tests/core/test_asset_decorator.py
Outdated
Show resolved
Hide resolved
…st_asset_decorator.py Co-authored-by: Rex Ledesma <[email protected]>
prha
force-pushed
the
prha/dbt_retry_policy
branch
from
5eb9538 to
3cb978b
Compare
danielgafni
pushed a commit
to danielgafni/dagster
that referenced
this pull request
Jun 18, 2024
## Summary & Motivation There's no way to pass a retry policy to a dbt asset. I assumed this was mostly an oversight, and not an explicit decision. Might need to sanity check that retries make sense in the dbt world. In a lot of cases, users will probably want to run `dbt retry` (instead of op-level retry) to not lose the per-model granularity of failures, but there is a case to be made to still configure a coarse-grained op-level retry with the standard retry options (e.g. delay, jitter, etc) ## How I Tested These Changes BK --------- Co-authored-by: Rex Ledesma <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
There's no way to pass a retry policy to a dbt asset. I assumed this was mostly an oversight, and not an explicit decision.
Might need to sanity check that retries make sense in the dbt world.
In a lot of cases, users will probably want to run
dbt retry(instead of op-level retry) to not lose the per-model granularity of failures, but there is a case to be made to still configure a coarse-grained op-level retry with the standard retry options (e.g. delay, jitter, etc)How I Tested These Changes
BK