Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(dbt): assert that dbt retry can be invoked to yield Output events #20395

Merged
merged 1 commit into from
Mar 11, 2024

Conversation

rexledesma
Copy link
Contributor

Summary & Motivation

Put #18990 (comment) under test.

How I Tested These Changes

pytest

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @rexledesma and the rest of your teammates on Graphite Graphite

@rexledesma rexledesma force-pushed the rl/dbt-retry-jaffle-shop branch 2 times, most recently from 5101b91 to a01325b Compare March 11, 2024 05:29
@rexledesma rexledesma force-pushed the rl/dbt-retry-jaffle-shop branch from a01325b to 20b6da3 Compare March 11, 2024 05:31
@rexledesma rexledesma marked this pull request as ready for review March 11, 2024 13:40
assert not list(dbt_invocation.stream())

yield from dbt.cli(["seed"], context=context).stream()
yield from replace(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this necessary when context=context is set on the line above?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, since the manifest and dagster_dbt_translator arguments to DbtCliInvocation are created in the DbtCliResource.cli(...) method, not the DbtCliInvocation.run(...) method.

We could change that behavior, but I was planning on circumventing the usage of replace altogether.

@rexledesma rexledesma merged commit 87afb91 into master Mar 11, 2024
1 check passed
@rexledesma rexledesma deleted the rl/dbt-retry-jaffle-shop branch March 11, 2024 14:29
PedramNavid pushed a commit that referenced this pull request Mar 28, 2024
…vents (#20395)

## Summary & Motivation
Put
#18990 (comment)
under test.

## How I Tested These Changes
pytest
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants