Skip to content

Commit

Permalink
[ui] Fix tags on backfill table (#26126)
Browse files Browse the repository at this point in the history
## Summary & Motivation

Fix stretched tags on Backfill table.

The row cells are flex column containers with no `alignItems` value set,
so the children stretch, causing `Tag` elements to occupy the entire
cell width.

It's not really safe to change `RowCell` to have `align-items:
flex-start` since that would have broader/riskier impact on other table
views, so the simple thing to do here is just wrap the `Tag` elements in
`div`s.

## How I Tested These Changes

View a backfill table with tags, verify that they no longer stretch.

## Changelog

[ui] Fix stretched tags in backfill table view for non-partitioned
assets.
  • Loading branch information
hellendag authored Nov 26, 2024
1 parent d62cafd commit 43183c3
Showing 1 changed file with 23 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -250,15 +250,33 @@ export const VirtualizedBackfillPartitionsRow = ({
<RowCell>-</RowCell>
<RowCell>
{inProgress ? (
<Tag icon="spinner" intent="primary">
In progress
</Tag>
<div>
<Tag icon="spinner" intent="primary">
In progress
</Tag>
</div>
) : (
'-'
)}
</RowCell>
<RowCell>
{completed ? (
<div>
<Tag intent="success">Completed</Tag>
</div>
) : (
'-'
)}
</RowCell>
<RowCell>
{failed ? (
<div>
<Tag intent="danger">Failed</Tag>
</div>
) : (
'-'
)}
</RowCell>
<RowCell>{completed ? <Tag intent="success">Completed</Tag> : '-'}</RowCell>
<RowCell>{failed ? <Tag intent="danger">Failed</Tag> : '-'}</RowCell>
</>
)}
</RowGrid>
Expand Down

1 comment on commit 43183c3

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deploy preview for dagit-core-storybook ready!

✅ Preview
https://dagit-core-storybook-hhjm1mzpp-elementl.vercel.app

Built with commit 43183c3.
This pull request is being automatically deployed with vercel-action

Please sign in to comment.