Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernize the hybrid-quickstart repo #4

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions Dockerfile
Original file line number Diff line number Diff line change
@@ -1,8 +1,11 @@
FROM python:3.8-slim

COPY requirements.txt /requirements.txt
RUN pip install -r /requirements.txt
COPY setup.py /
RUN pip install .

WORKDIR /opt/dagster/app

COPY . /opt/dagster/app
COPY . /opt/dagster/app

# Make sure dagster-cloud is installed. Fail early here if not.
RUN dagster-cloud --version
5 changes: 2 additions & 3 deletions dagster_cloud.yaml
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
locations:
- location_name: example_location
- location_name: quickstart_etl
code_source:
package_name: my_dagster_project
package_name: quickstart_etl
build:
directory: ./
registry: 764506304434.dkr.ecr.us-west-2.amazonaws.com/branch-deployments-gh-action-test

1 change: 0 additions & 1 deletion my_dagster_project/__init__.py

This file was deleted.

11 changes: 0 additions & 11 deletions my_dagster_project/repository.py

This file was deleted.

11 changes: 0 additions & 11 deletions my_dagster_project_tests/test_assets.py

This file was deleted.

3 changes: 3 additions & 0 deletions pyproject.toml
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
[build-system]
requires = ["setuptools"]
build-backend = "setuptools.build_meta"

[tool.dagster]
module_name = "quickstart_etl"
16 changes: 16 additions & 0 deletions quickstart_etl/__init__.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
from dagster import (
Definitions,
ScheduleDefinition,
define_asset_job,
load_assets_from_package_module,
)

from . import assets

daily_refresh_schedule = ScheduleDefinition(
job=define_asset_job(name="all_assets_job"), cron_schedule="0 0 * * *"
)

defs = Definitions(
assets=load_assets_from_package_module(assets), schedules=[daily_refresh_schedule]
)
File renamed without changes.
Empty file.
2 changes: 1 addition & 1 deletion setup.cfg
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
[metadata]
name = my_dagster_project
name = quickstart_etl
10 changes: 8 additions & 2 deletions setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,15 @@

if __name__ == "__main__":
setup(
name="my_dagster_project",
packages=find_packages(exclude=["my_dagster_project_tests"]),
name="quickstart_etl",
packages=find_packages(exclude=["quickstart_etl_tests"]),
install_requires=[
"dagster",
"dagster-cloud",
"pandas",
"matplotlib",
"textblob",
"tweepy",
"wordcloud",
],
)
2 changes: 0 additions & 2 deletions workspace.yaml

This file was deleted.