further specify concurrency group #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes! I think this has been broken in hooli and dogfood as well. Great catch |
slopp
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the hybrid quickstart gh action, I ended up running into an issue where when merging a PR after a branch deployment successfully ran, the branch close flow would run in the same group as the main flow, since the ref is the same, and one of the runs would be canceled. The result was that the branch deployment closed and nothing else.
This fixes by also indexing on the name of the event, which i think gets closer to the intended affect.
I can verify that this also fixed on my run of the action. See original: https://github.com/dagster-io/base-dagster-repo/actions/runs/12040973366
and after: https://github.com/dagster-io/base-dagster-repo/actions/runs/12041102759