prevents sync from setting unset attrs to undef #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This seems quite sensible. Could you please add a test of the new behavior? It should fail without the commit you have and pass with it. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the sync method loops through all attributes in the target object and sets them with the source value for the corresponding attribute. This means that even unset attributes in the source will become set, undef attributes in the resulting object.
It is important to maintain the difference between attrs set to undef (null fields in document) and attrs that are unset (non-existent fields in document), and this commit ensures that distinction is made when using "sync".
I believe this should be the desired behavior, although it could certainly break backwards compatibility if people have adapted to the existing behavior. Thoughts?