Adding folder time info #1752
Merged
Adding folder time info #1752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dadoonet
requested changes
Nov 24, 2023
beans/src/main/java/fr/pilato/elasticsearch/crawler/fs/beans/Folder.java
Outdated
Show resolved
Hide resolved
|
The docker build issue is something I need to fix on my end. |
Remove blank lines
dadoonet
approved these changes
Nov 24, 2023
|
@bdauvissat Sorry. Bad news. I merged a big change before applying your fix and that now requires more edits on your side. |
|
I will take a look at it. |
added 2 commits
November 24, 2023 15:37
# Conflicts: # settings/src/main/resources/fr/pilato/elasticsearch/crawler/fs/_default/7/_settings_folder.json # settings/src/main/resources/fr/pilato/elasticsearch/crawler/fs/_default/8/_settings_folder.json # settings/src/test/java/fr/pilato/elasticsearch/crawler/fs/settings/FsMappingTest.java
|
@bdauvissat Could you merge the master branch in your branch? I made some changes that should most of the time fix the Build jobs. |
|
dadoonet
requested changes
Jan 14, 2024
beans/src/main/java/fr/pilato/elasticsearch/crawler/fs/beans/Folder.java
Outdated
Show resolved
Hide resolved
core/src/main/java/fr/pilato/elasticsearch/crawler/fs/FsParserAbstract.java
Outdated
Show resolved
Hide resolved
|
Also, could you add this new feature in https://github.com/dadoonet/fscrawler/blob/master/docs/source/release/2.10.rst? |
added 2 commits
January 20, 2024 17:40
Correcting date import and using existing methods for extracting dates for the folder
|
dadoonet
approved these changes
Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I chose to pass the three dates as arguments instead of inside an object because the most suitable object would be File but
fr.pilato.elasticsearch.crawler.fs.FsParserAbstractusesjava.io.Filewhilefr.pilato.elasticsearch.crawler.fs.beans.Folderusesfr.pilato.elasticsearch.crawler.fs.beans.File.