Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Bootstrap 5 layout support #500

Conversation

mackrais
Copy link
Contributor

Q A
Bug fix? no
New feature? ye
BC breaks? no
Deprecations? no
Fixed tickets ...

Added bootstrap 5 layout support and added docs how make custom form theme template.

Frontend
dachcom-digital/jquery-pimcore-formbuilder#4
dachcom-digital/js-pimcore-formbuilder#28

I have read the CLA Document and I hereby sign the CLA

Copy link

github-actions bot commented Dec 21, 2024

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@solverat solverat added this to the 5.2.0 milestone Jan 8, 2025
@solverat
Copy link
Member

solverat commented Jan 8, 2025

@mackrais thank you for your contribution. Please sign the CLA (I guess it needs to be a separate comment).

README.md Outdated Show resolved Hide resolved
docs/110_CustomTemplates.md Show resolved Hide resolved
@mackrais
Copy link
Contributor Author

mackrais commented Jan 9, 2025

I have read the CLA Document and I hereby sign the CLA

@mackrais mackrais force-pushed the feature/support-bootstrap5-layout-template branch from e1c7151 to 2c72fac Compare January 9, 2025 10:44
@solverat
Copy link
Member

solverat commented Jan 9, 2025

Hey @mackrais thank you so much for your efforts!

Tests failing because of icu changes and already has been fixed. Ignoring.

@solverat solverat merged commit d24810e into dachcom-digital:master Jan 9, 2025
3 of 4 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants