Fix natural scroll when reaching extent #188
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spetex
commented
Aug 27, 2019
| @@ -76,7 +77,6 @@ export default function() { | |||
| .on("touchstart.zoom", touchstarted) | |||
| .on("touchmove.zoom", touchmoved) | |||
| .on("touchend.zoom touchcancel.zoom", touchended) | |||
| .style("touch-action", "none") | |||
There was a problem hiding this comment.
Have not found the reason for this class. It unfortunately prevents natural page scroll to apply. We can probably programatically add and remove the class during the touchmove if it is necessary.
spetex
commented
Aug 27, 2019
|
|
||
| var move = constrain(translate(t, p, l), g.extent, translateExtent); | ||
|
|
||
| if ((move.x != 0 || move.y != 0) && !touchScroll) { |
There was a problem hiding this comment.
touchScroll we need to prevent the noevent() when you are already scrolling the page, the browser ingores it anyways
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in the issue: #186
I am preventing pan and event cancellation if the content has reached the translateExtent.
I have tested this on an iPhone and multiple different browsers I have on my laptop.