Fix for define(name, factory).

d3 · Mar 5, 2018 · 4001f0f · 4001f0f
1 parent d892280
commit 4001f0f
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 2 deletions.
diff --git a/index.js b/index.js
@@ -66,8 +66,9 @@ function isexports(name) {
 }
 
 function define(name, dependencies, factory) {
-  if (arguments.length < 3) factory = dependencies, dependencies = name;
-  if (arguments.length < 2) factory = dependencies, dependencies = [];
+  var n = arguments.length;
+  if (n < 2) factory = name, dependencies = [];
+  else if (n < 3) factory = dependencies, dependencies = typeof name === "string" ? [] : name;
   queue.push(some.call(dependencies, isexports) ? function(require) {
     var exports = {};
     return Promise.all(map.call(dependencies, function(name) {

diff --git a/test/test-cellauto.html b/test/test-cellauto.html
@@ -0,0 +1,9 @@
+<!DOCTYPE html>
+<script src="/build/d3-require.js"></script>
+<script>
+
+d3.require("https://cdn.rawgit.com/sanojian/cellauto/a72966c7e422b4c66f8ad0e0de3a8633055c77be/dist/cellauto.js").then($ => {
+  console.log($);
+});
+
+</script>