Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Binary prefix, Currency prefix (Merge #70 #81) #96
Implement Binary prefix, Currency prefix (Merge #70 #81) #96
Changes from 16 commits
1dfc9ad
1841fbc
b43ed9e
2fb8dbd
e33a8f1
e249b2e
d1ed244
fad5de7
3fa19c7
7ee5a2c
a0de748
76c6681
1299824
b05d382
4bc47b3
fffdb7d
9794256
03ffad2
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We might want to mention here that these are for US English locale specifically.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these necessarily related to currency? IMO this formatter is useful for formatting large numbers in general, not specific to dealing with currency. Although, the currency use case gives some concrete grounding for decisions, which is great. Probably it's fine to call it
currencyPrecisionPrefix
, but it's actually a more general formatter.