Ophase Categories #129
Ophase Categories #129
Conversation
This has currently no further effects
Accessible through ManyToMany relation with additional fields Start and end date are calculated automatically Fixed naming issue (renamed field from begin_date to start_date for higher consistence) in OphaseActiveCategory Ophases have to be named now explicitly to resolve recursive call issues (of ophase and the intermediate table). Removed obsolete related methods
|
Not sure why the tests are failing with
suddenly. Has anyone an idea? Maybe @ckleemann? Also I am a little bit annoyed by those fake "new issues" of codeclimate from lots of files I did not even touch. |
For some migrations, a specific order had to be enforced manually
Added CASCADE deletion constants for foreign keys. Required in Python20
Added deletion constants for foreign keys. Required in Python20. Also changed null constraints. This commit may be cherry picked as it is not related to the features of this branch but was created during removing all warnings.
|
I was able to track down the error -- it was caused by migrations depending on a specific run order that was used locally during incremental migrations but not when populating a new database. No need to check anymore, @ckleemann. |
|
Contrary to the commit message of bd5c9e2, this commit cannot be cherry picked since a migration is contained (and the dependencies would not be fulfilled when picking). |
|
We would like to deploy this features asap so that the hompage of pyOphase can be updatet to the next Ophase. |
| @@ -13,10 +13,10 @@ class OphaseIsActive(TestCase): | |||
|
|
|||
| def test_only_one_is_active(self): | |||
| # create Ophase - should be active | |||
| o1 = Ophase.objects.create(start_date=date(2014, 4, 7), end_date=date(2014, 4, 11), is_active=True) | |||
| o1 = Ophase.objects.create(name="Testophase 1", is_active=True) | |||
There was a problem hiding this comment.
It appears to me as if this only tests the Ophase instance itself, not any OphaseCategories. You might want to add some OphaseActiveCategories to o1.
There was a problem hiding this comment.
I created issue #131 to make sure this does not fall into oblivion.
|
Reports are working, I just checked it. Squashing is probably not a good idea since I had to edit the migrations manually to make sure migrating works for existing databases as well as empty ones. The translations are already done on the main branch (with #128) and will be complete after merging. |
Added methods to filter Jobs using a given Ophase Allow only jobs that belong to the selected categories of the current Ophase
|
From my point of view, the essential work is done here and this branch can be merged. All further improvements and usages are enhancements and can be added when needed. |
The property is currently used to display the block on the frontpage of the website using the main language of the OphaseCategory
Introducing and using different categories for Ophase to e.g. allow a Ophase with only Master tutor groups (already possible without these changes) but also only Jobs for a Master Ophase (using changes from this branch/pull request).
Work in progress. Feel free to comment anyway.
This aims to resolve #56