This repository has been archived by the owner on Oct 22, 2024. It is now read-only.
Patch djangocms icons for d120 #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
relevant upstream issue: django-cms/djangocms-bootstrap4#124 |
|
I have added the website team since they are responsible for the maintenance of this project. |
bhaettasch
approved these changes
Oct 25, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a temporary fix to and config change for
djangocms-iconto be able to use the fontawesome 4 icons that are already used by the website.We likely need another fix to load the css in the admin views as well, kind of the inverse bug as we have now, where we can create font-awesome 5 icons because that is the default config and loaded from CDN in the admin but doesn't work in the frontend, because of the patched bug and the fact that we don't include the 5 icons at all.