Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent possible duplication avenues on extract/save questionnaire #58

Merged
merged 2 commits into from
Jun 25, 2024

Conversation

LZRS
Copy link
Collaborator

@LZRS LZRS commented Apr 29, 2024

IMPORTANT: Where possible all PRs must be linked to a Github issue

Fixes #[issue number]

Checklist

  • I have written Unit tests for any new feature(s) and edge cases for bug fixes
  • I have added any strings visible on UI components to the strings.xml file
  • I have updated the CHANGELOG.md file for any notable changes to the codebase
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the project's style guide
  • I have built and run the fhircore app to verify my change fixes the issue and/or does not break the app

LZRS added 2 commits April 29, 2024 22:05
to ensure once launched, can't be duplicated when on top of stack
@LZRS LZRS self-assigned this Apr 29, 2024
@sevenreup
Copy link

It would be better if this was mergeable with #42 or #56. Right now the programs are using the dev environment for most of their tests and they are using builds from these branches. I want to try and give them a build of this PR to tests so that we can see if the duplication happens when they are doing their normal tests on dev.

@sevenreup sevenreup merged commit d94ae4a into mwcore-dev Jun 25, 2024
3 checks passed
@sevenreup sevenreup deleted the test-fix-duplicated-extraction branch June 25, 2024 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants