Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Bangladesh Inter university Nationals Debate Format #37

Closed
wants to merge 9 commits into from

Conversation

Taraldinn
Copy link

This debate format is popular and main stream debate format in Bangladesh.
It is Three VS Three
5 Minutes of Speech
3 minutes Replies

Copy link
Owner

@czlee czlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Taraldinn, thanks for submitting this! It'd be great to have it in the repository. I'm requesting a few changes to align with stylistic guidelines.

If you haven't already, please have a look at our contributing guidelines: https://github.com/czlee/debatekeeper-formats/blob/main/.github/CONTRIBUTING.md

v1/formats.json Outdated
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to update this file—I have GitHub workflows to do this automatically, which is preferable because it copies information from the XML file 😊 Would you please remove it from the PR?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry for late review . I was busy with something ? Will I remove this PR right now ?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Taraldinn You don't owe an apology for attending to something here three days later! Absolutely no deadlines in this repository, I'd be in such a glass house if I tried to imply any. It's just a spare-time project 😀

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The file name needs to be lower case, so bdiv.xml.

v1/formats/BDIV.xml Outdated Show resolved Hide resolved
<speech-types>
<speech-type ref="substantive" length="5:00" first-period="normal">
<bell time="1:00" number="1" next-period="pois-allowed"/>

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove this blank line

v1/formats/BDIV.xml Outdated Show resolved Hide resolved
Taraldinn and others added 3 commits April 12, 2024 19:20
Changes in code

Co-authored-by: Chuan-Zheng Lee <[email protected]>
version will 1

Co-authored-by: Chuan-Zheng Lee <[email protected]>
@Taraldinn Taraldinn closed this Apr 12, 2024
@Taraldinn Taraldinn reopened this Apr 12, 2024
@Taraldinn Taraldinn closed this Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants