UI-337 Create dropdown menu to replace DETabPanel in Apps #340
Conversation
|
Thanks for the review! |
|
|
||
| @Override | ||
| public void insert(Widget widget, int index, String name) { | ||
| if (!selectionMap.containsKey(widget)) { |
There was a problem hiding this comment.
I was wondering why not use a regular ComboBox over the SimpleComboBox + this selectionMap, but it does seem this widget lookup here is much simpler than trying to find the widget in a ComboBox list store 🤔
There was a problem hiding this comment.
Well for one, I totally forgot about the regular ComboBox lol
But if I do remember correctly, I think ComboBox was better suited for a list of items of the same type which all had the same method/property that could be used to extract the display name. This is a combo of Trees but they're not all of the same type (OntologyHierarchy, AppCategory, Group), so I'm not sure that would work. I could be wrong though, it's been a while since I've used one.
|
Thanks for the reviews! Since the release is on Tuesday, I think I'll wait to see how far I get with the admin interface for Communities to determine if these should be merged with the release or merged afterwards. |
|
I'm going to close this since we decided to go a different direction for the communities listing in the DE - instead of having Communities be a separate tab/option, they'll be part of our current My Apps workspace tab |
This doesn't complete UI-337, but gets us ready to add the Communities option by switching to the dropdown.