Fix fill color for test results icon #505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 86d8541 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| @@ -1,4 +1,4 @@ | |||
| <svg viewBox="0 0 16 16" fill="none" xmlns="http://www.w3.org/2000/svg"> | |||
| <path d="M1 10H4V13H1V10Z" fill="currentColor" class="icon-dark" /> | |||
| <path d="M1 10H4V13H1V10Z" fill="#D0D2E0" class="icon-light" /> | |||
There was a problem hiding this comment.
Shouldn't this continue to be currentColor?
There was a problem hiding this comment.
I was following what the x24 version had since it allowed changing the color of that part, but I guess it's the class that matters more. I reverted this one and updated the x24 to match.
cypress-design
|
||||||||||||||||||||||||||||||||||||||||
| Project |
cypress-design
|
| Branch Review |
chrisbreiding/fix-test-results-fill-color
|
| Run status |
|
| Run duration | 02m 37s |
| Commit |
|
| Committer | Chris Breiding |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
222
|
| View all changes introduced in this branch ↗︎ | |
UI Coverage
11.36%
|
|
|---|---|
|
Untested elements
|
166
|
|
Tested elements
|
25
|
Accessibility
99.37%
|
|
|---|---|
|
Failed rules
|
0 critical
1 serious
0 moderate
1 minor
|
|
Failed elements
|
22
|
emilyrohrbough
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without the
icon-lightclass, it's not possible to change the little box's fill color separately from the rest of the icon.