Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Accessiblity & UI Coverage disabled icons #499

Merged
merged 4 commits into from
Nov 13, 2024
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/giant-steaks-rhyme.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@cypress-design/icon-registry': patch
---

Add Accessiblity & UI Cov skipped icons.
6 changes: 4 additions & 2 deletions ReadMe.md
Original file line number Diff line number Diff line change
Expand Up @@ -95,10 +95,12 @@ The name and size should match what's shown in Figma.

Once added, the svg attributes should be tweaked so as to integrate with the icon generation tooling.

- Replace the main color with `currentColor`
- Remove the `width` and `height` attributes of the SVG
- Replace the main color fill and/or stroke colors with `currentColor`
- Add `class="icon-dark"` to paths that are dark, generally the strokes
- Add `class="icon-light"` to paths that are light, generally the fills
- Remove the `width` and `height` attributes of the SVG
- For secondary colors are used in the design, use `class="icon-*-secondary"`
- When `fill` and `stroke` attributes are both uses in the path, you can use `class="icon-dark-stroke icon-light-fill"`

To verify that the icon is properly hooked up, run `yarn && yarn start` and navigate to the `icons` page. Search for your icon and tweak the colors.

Expand Down
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading