Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix-icon-types-and-ts-maps #340

Merged
merged 3 commits into from
Nov 14, 2023
Merged

Fix-icon-types-and-ts-maps #340

merged 3 commits into from
Nov 14, 2023

Conversation

elevatebart
Copy link
Contributor

@elevatebart elevatebart commented Nov 14, 2023

  • Icons autocomplete and attribute validation did not work FIXED
  • details-animation was not using sourcemaps properly triggering a ViteJs warning FIXED

Copy link

changeset-bot bot commented Nov 14, 2023

🦋 Changeset detected

Latest commit: 8f53679

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@cypress-design/details-animation Patch
@cypress-design/vue-icon Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Nov 14, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
cypress-design ✅ Ready (Inspect) Visit Preview Nov 14, 2023 4:45pm

Copy link

cypress bot commented Nov 14, 2023

Passing run #1462 ↗︎

0 136 0 0 Flakiness 0

Details:

add changeset
Project: cypress-design Commit: 8f53679a86
Status: Passed Duration: 03:01 💡
Started: Nov 14, 2023 4:47 PM Ended: Nov 14, 2023 4:50 PM

Review all test suite changes for PR #340 ↗︎

@elevatebart elevatebart merged commit 1c85485 into main Nov 14, 2023
6 checks passed
@elevatebart elevatebart deleted the fix-icon-types-and-ts-maps branch November 14, 2023 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant