[DESIGN-1854] Light tooltip - Increasing drop-shadow for two increments #321
Conversation
|
Task linked: DESIGN-1854 Improve Light Tooltip Shadows |
🦋 Changeset detectedLatest commit: f22159e The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
@emilmilanov Actually, I just checked how this looks in the preview environment and on dark backgrounds this solution starts to break down a little bit. My suggestion would be to aim for a transparent dark gray shadow (like what we find in Figma). Otherwise, we could consider applying the darken filter on just the drop-shadow, but that would likely be harder to get that to work honestly.
Here's a screenshot:
|
@ryanjwilke on dark backgrounds, the light tooltip stays very visible so we do not have as much a need to see the shadow. |
|
@elevatebart Your comment is more functional in nature. I’m actually referring to something visual in that it would look weird to see a gray shadow on backgrounds that are not white. It may have worked fine for an initial iteration, but we should strive for a solution that brings us closer to the Figma design system. The drop-shadow really only serves a purpose on lighter backgrounds. All other colors and darker backgrounds, the shadow should essentially be invisible. |
|
Thank you for pointing it out. Don't hesitate to ping me if you are looking for tech solutions. |
|
@elevatebart This is ready for a review. I updated It seems like my VS code automatically added few |
Passing run #1367 ↗︎
Details:
Review all test suite changes for PR #321 ↗︎ |
|||||||||||||||
|
Looks good to me! |
Clickup link: https://cypress.clickup.com/t/18033298/DESIGN-1854
Before:
After:
