fix: open links with target=_blank in CustomTabs, same behavior as chrome PWAs #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a chrome-created PWA on Android, if the user clicks a link with
target=_blank(requesting link to be opened in a new tab), the link will be opened in a newly-popped-up browser activity (CustomTabs) , instead of navigating the main app page to the link or opening it in system browser.This behavior is particularly important for SPAs like a music player, where the user could be listening to some music and browsing around, and opening links in new tab as requested can have the music playback uninterrupted.
However in current Native Alpha behavior such a click would make the main app page to navigate to the link and interrupt the playing music in main app page. This PR fixes this and make Native Alpha behave the same as chrome PWAs.