build,refactor: fix build.gradle files with new repos added, refactor… #94
Conversation
… and remove obsolete dependency for hashing, use native method instead
There was a problem hiding this comment.
jcenter() is deprecated and we should move to use mavenCentral(). I tried to remove directly, but it has certain dependencies in the code that resulted for the build to fail but did caused no harm when I removed jcenter() from project's build.gradle
Also, I suggest you to update the gradle to 7.3.1
| @@ -116,8 +116,7 @@ dependencies { | |||
| implementation 'com.mikhaellopez:circularprogressbar:3.0.3' | |||
| implementation 'org.jsoup:jsoup:1.14.1' | |||
| // https://gitlab.com/eyeo/distpartners/libadblockplus-android/-/tags | |||
| implementation 'org.adblockplus:adblock-android-webview:5.0.1' | |||
There was a problem hiding this comment.
Given version was not resolving properly (I tried to investigate it but with no result). That version builds fine
There was a problem hiding this comment.
This caused issues with AdBlock feature or functioning of the app overall?
There was a problem hiding this comment.
Gradle couldn't find this version and download it
There was a problem hiding this comment.
Android Studio suggessted me to update to 7.3.1 along with other libraries
There was a problem hiding this comment.
Does it build successfully for you with 5.0.1?
There was a problem hiding this comment.
Understandable. The app uses many old libraries and functionalities that easily breaks upon upgrading. I got to know about these by the logs in CI/CD.
Yes, I was able to build it directly. I did even upgrade the things. I cherry picked your commit yesterday to my repo and they'll eventually got downgraded. Haven't checked it yet due to lack of time.
There was a problem hiding this comment.
maybe it's due to repo havingt only 4.4.0 listed
https://mvnrepository.com/artifact/org.adblockplus/adblock-android-webview?repo=jcenter
There was a problem hiding this comment.
I just tried to build and yes, yes it failed now. I wonder why and how did that failed as I was able to build it yesterday as well as day before yesterday.
maybe it's due to repo havingt only 4.4.0 listed
This IMO might be one of the possible reason. I still personally prefer uBlock over adblock tho.
There was a problem hiding this comment.
Me too. But I just wanted to hot fix stuff in order to build the repo. There was no reasoning behind decisions I made apart from successful build. You can change it however you like, though.
… and remove obsolete dependency for hashing, use native method instead
Please kindly ask you to merge