Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make ListCollection and TreeCollection satisfy the Collection interface #1

Merged
merged 1 commit into from
May 14, 2024

Conversation

nishitaniyuki
Copy link
Collaborator

@nishitaniyuki nishitaniyuki commented May 14, 2024

Currently, ListCollection and TreeCollection does not satisfy the Collection interface, because getKeyBefore() and getKeyAfter() could return undefined. The details are as follows.

Collection interface:

ListCollection:

TreeCollection:

For example, if we replace state.collection.getKeyAfter(item.key) == null in useDraggableCollection() docs with state.collection.getKeyAfter(item.key) === null, things does not work as expected (according to the type definition this is valid).

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

@nishitaniyuki nishitaniyuki self-assigned this May 14, 2024
@nishitaniyuki
Copy link
Collaborator Author

@nishitaniyuki nishitaniyuki merged commit 4be0f16 into fix-collections May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant