make ListCollection and TreeCollection satisfy the Collection interface #1
+4
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, ListCollection and TreeCollection does not satisfy the Collection interface, because
getKeyBefore()
andgetKeyAfter()
could returnundefined
. The details are as follows.Collection interface:
getKeyBefore()
andgetKeyAfter()
returnKey
ornull
Key
isstring
ornumber
ListCollection:
node.prevKey
andnode.nextKey
can beundefined
ListCollection.getKeyBefore()
andListCollection.getKeyAfter()
can returnundefined
TreeCollection:
node.prevKey
andnode.nextKey
can beundefined
TreeCollection.getKeyBefore()
andTreeCollection.getKeyAfter()
can returnundefiend
For example, if we replace
state.collection.getKeyAfter(item.key) == null
inuseDraggableCollection()
docs withstate.collection.getKeyAfter(item.key) === null
, things does not work as expected (according to the type definition this is valid).✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: