Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clearpath Heron USV #6548

Merged
merged 45 commits into from
Nov 23, 2024
Merged

Conversation

harunkurtdev
Copy link
Contributor

Description
Clearpath's USV vehicle named Heron has been added.

Tasks
Add the list of tasks of this PR.

  • New Robot

Screenshots
ocean
swarm

@harunkurtdev harunkurtdev requested a review from a team as a code owner May 11, 2024 13:01
@omichel
Copy link
Member

omichel commented May 11, 2024

There are several errors reported by the CI on the "Test Sources". In particular:

/home/runner/work/webots/webots/projects/robots/clearpath/heron/controllers/heron_usv_controller/heron_usv_controller.py:29:1: W293: blank line contains whitespace
/home/runner/work/webots/webots/projects/robots/clearpath/heron/controllers/heron_usv_controller/heron_usv_controller.py:46:1: W293: blank line contains whitespace
Missing ".wproj" file: "/home/runner/work/webots/webots/projects/robots/clearpath/heron/worlds/.swarm.wbproj"
Wrong line ending in file: "/home/runner/work/webots/webots/projects/robots/clearpath/heron/obj/boat.obj"
missing icon: "/home/runner/work/webots/webots/projects/robots/clearpath/heron/protos/Heron.proto"
Wrong header in file: "/home/runner/work/webots/webots/projects/robots/clearpath/heron/protos/Heron.proto"

etc.

Can you please fix them?

@harunkurtdev
Copy link
Contributor Author

I fix that bugs @omichel

@omichel
Copy link
Member

omichel commented May 13, 2024

Thank you. Could you please also write a short documentation? This is required for robots distributed in Webots.

@harunkurtdev
Copy link
Contributor Author

@omichel I finish all of for document, can you check ?

@ShuffleWire ShuffleWire mentioned this pull request Aug 8, 2024
48 tasks
@harunkurtdev
Copy link
Contributor Author

@omichel sir can you check ? #6597

@harunkurtdev
Copy link
Contributor Author

Instead of storing the stl files in an obj folder, it would be better to store them in a stl folder.

okey sir.

@harunkurtdev
Copy link
Contributor Author

mr. @omichel , can you check ?

Copy link
Member

@omichel omichel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned, I would also appreciate if you can fix the icon which should be a screenshot of the simulated robot, not the real one.

projects/robots/clearpath/heron/worlds/ocean.wbt Outdated Show resolved Hide resolved
Copy link
Member

@omichel omichel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see my latest comment.

@harunkurtdev
Copy link
Contributor Author

Please see my latest comment.

sir, I changed icon.

Unknown-4

@harunkurtdev
Copy link
Contributor Author

mr. @omichel, can you review ?

is it all of done ?

Copy link
Member

@omichel omichel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As already requested, please remove the linearVelocity and angularVelocity useless fields from all the world and proto files.

@harunkurtdev
Copy link
Contributor Author

As already requested, please remove the linearVelocity and angularVelocity useless fields from all the world and proto files.

Sir, removed linearVelocity and angularVelocity.

Copy link
Member

@omichel omichel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@harunkurtdev
Copy link
Contributor Author

Thank you.

Sir,

Thank you very much indeed for your feedback.

@omichel omichel merged commit 1ad0a69 into cyberbotics:master Nov 23, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants