Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Change sample app config default value for Test Mode to "NO" #463

Merged
merged 1 commit into from
Nov 11, 2024

Conversation

mahmoud-elmorabea
Copy link
Contributor

This PR changes the sample app config value of "Test Mode" to "No"

The motivation is that this by default aligns more closely to the settings our customers would be using when integrating the SDK into their apps.

@mahmoud-elmorabea mahmoud-elmorabea self-assigned this Nov 7, 2024
Copy link

github-actions bot commented Nov 7, 2024

Sample app builds 📱

Below you will find the list of the latest versions of the sample apps. It's recommended to always download the latest builds of the sample apps to accurately test the pull request.


Copy link

github-actions bot commented Nov 7, 2024

  • java_layout: MBL-639-sample-app-default-test-mode (1731002125)

Copy link

github-actions bot commented Nov 7, 2024

📏 SDK Binary Size Comparison Report

No changes detected in SDK binary size ✅

Copy link

github-actions bot commented Nov 7, 2024

  • kotlin_compose: MBL-639-sample-app-default-test-mode (1731002126)

Copy link

codecov bot commented Nov 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.82%. Comparing base (8b30804) to head (d202622).
Report is 17 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #463      +/-   ##
============================================
+ Coverage     41.98%   51.82%   +9.84%     
- Complexity      259      290      +31     
============================================
  Files            99       96       -3     
  Lines          2320     2570     +250     
  Branches        344      352       +8     
============================================
+ Hits            974     1332     +358     
+ Misses         1247     1135     -112     
- Partials         99      103       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mahmoud-elmorabea mahmoud-elmorabea marked this pull request as ready for review November 7, 2024 18:11
Copy link

github-actions bot commented Nov 8, 2024

Build available to test
Version: MBL-639-sample-app-default-test-mode-SNAPSHOT
Repository: https://s01.oss.sonatype.org/content/repositories/snapshots/

@mahmoud-elmorabea mahmoud-elmorabea requested a review from a team November 8, 2024 14:45
@mahmoud-elmorabea mahmoud-elmorabea merged commit da9afb8 into main Nov 11, 2024
36 checks passed
@mahmoud-elmorabea mahmoud-elmorabea deleted the MBL-639-sample-app-default-test-mode branch November 11, 2024 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants