Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: segment compatibility #2

Merged
merged 14 commits into from
May 7, 2024
Merged

fix: segment compatibility #2

merged 14 commits into from
May 7, 2024

Conversation

Shahroz16
Copy link
Collaborator

@Shahroz16 Shahroz16 commented Apr 1, 2024

Problem:
Our fork and Segment SDK can't be added at the same time via SPM.

Solution:
Update module name from Segment to CioAnalytics.

Changes:

  • Package.json for updated module name
  • Podspec for updated module name
  • External Module reference of Segment
  • Sample Apps
  • Objc symbols to avoid linker issues because of same objc names

@Shahroz16 Shahroz16 marked this pull request as draft April 1, 2024 08:58
@PaulWen
Copy link

PaulWen commented Apr 22, 2024

Hi @Shahroz16, I just tried to upgrade from CIO 2x to CIO 3x but I am now blocked as we already have the Segment SDK in place and can't add this library at the same time via SPM.

Two questions:

  1. What does CIO use this library for?
  2. When is this PR expected to be merged or is there any alternative way to upgrade to CIO 3x while also having the Segment SDK installed via SPM?

Thanks!

@Shahroz16
Copy link
Collaborator Author

Hey @PaulWen, thank you for your feedback. As customerio/customerio-ios#670, we are currently evaluating the effort required to support both SDKs running in parallel, but we haven't finalized a solution yet.

In the meantime, you can continue using V2, as it is fully supported and compatible with analytics-swift SDK. We will keep you updated on any developments.

Since V3 offers support for our CDP, we utilize features of Segment SDK. If you have any additional feedback or more use cases to share regarding the integration of analytics-swift SDK with V3 (as in our using both CIO CDP and Segment or just wanted to utilize some of v2 features of CIO), please do share with us. If it's easier to share privately you can email [email protected] to start a thread with our product team.

@Shahroz16 Shahroz16 marked this pull request as ready for review May 6, 2024 22:25
@Shahroz16 Shahroz16 requested a review from a team May 6, 2024 22:25
Copy link

@mrehan27 mrehan27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍🏻

AnalyticsSwiftCIO.podspec Outdated Show resolved Hide resolved
@Shahroz16 Shahroz16 merged commit a9ef2bd into main May 7, 2024
1 of 8 checks passed
@Shahroz16 Shahroz16 deleted the shahroz/different-target branch May 7, 2024 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants