Use if instead of $?

cuiyourong · Jun 19, 2022 · 34c32a8 · 34c32a8
1 parent e5748eb
commit 34c32a8
Showing 1 changed file with 5 additions and 4 deletions.
diff --git a/rustup-init.sh b/rustup-init.sh
@@ -72,10 +72,11 @@ main() {
     local _url="${RUSTUP_UPDATE_ROOT}/dist/${_arch}/rustup-init${_ext}"
 
     local _dir
-    _dir="$(ensure mktemp -d)"
-    # Because the previous command ran in a subshell, we must manually propagate
-    # exit status.
-    [ $? -ne 0 ] && exit 1
+    if ! _dir="$(ensure mktemp -d)"; then
+        # Because the previous command ran in a subshell, we must manually
+        # propagate exit status.
+        exit 1
+    fi
     local _file="${_dir}/rustup-init${_ext}"
 
     local _ansi_escapes_are_valid=false