-
-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README.md, python example #235
Conversation
Add the uri field which is required by the current implementation of `Compiler`.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I asked a question, to understand a little more. (I don't know the Compiler interface!)
@@ -128,6 +128,7 @@ from gherkin.pickles.compiler import Compiler | |||
|
|||
parser = Parser() | |||
gherkin_document = parser.parse("Feature: ...") | |||
gherkin_document["uri"] = "uri_of_the_feature.feature" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔍 Looks good! Thanks!
Minor question, not a blocker: Is "uri_of_the_feature.feature"
an acceptable "uri", here?
- If yes, that's cool,
- If not, perhaps we can use something that would be a real URI, (e.g.
"file:///home/alice/projects/my_app/uri_of_the_feature.feature"
,"http://example.com/gherkin_features/uri_of_the_feature.feature"
)
(Minor question #2: can Parser.parse dig out "uri" out of given text to parse? Sounds improbable.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I copied this URL from another language's example. We can pick an example url and change it everywhere.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need to, change, let's merge this improvement as it stands , thanks for filling me in.
Hi @jeanlauliac, Thanks for your making your first contribution to Cucumber, and welcome to the Cucumber committers team! You can now push directly to this repo and all other repos under the cucumber organization! 🍾 In return for this generous offer we hope you will:
On behalf of the Cucumber core team, |
🤔 What's changed?
Add the uri field which is required by the current implementation of
Compiler
.🏷️ What kind of change is this?
📋 Checklist:
This text was originally generated from a template, then edited by hand. You can modify the template here.