Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DQM: Adding protections for runs with 21 masked pixels (due to shutter) #80

Merged
merged 13 commits into from
Oct 24, 2023

Conversation

hashkar
Copy link
Collaborator

@hashkar hashkar commented Oct 20, 2023

The camera geometry was already fixed. This pull request has small bug and style fixes

@codecov
Copy link

codecov bot commented Oct 20, 2023

Codecov Report

Attention: 74 lines in your changes are missing coverage. Please review.

Comparison is base (39b677b) 5.61% compared to head (c138ae5) 5.64%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##           master     #80      +/-   ##
=========================================
+ Coverage    5.61%   5.64%   +0.02%     
=========================================
  Files          37      37              
  Lines        3667    3649      -18     
=========================================
  Hits          206     206              
+ Misses       3461    3443      -18     
Files Coverage Δ
src/nectarchain/dqm/trigger_statistics.py 0.00% <0.00%> (ø)
src/nectarchain/dqm/dqm_summary_processor.py 0.00% <0.00%> (ø)
src/nectarchain/dqm/start_calib.py 0.00% <0.00%> (ø)
src/nectarchain/dqm/mean_camera_display.py 0.00% <0.00%> (ø)
src/nectarchain/dqm/charge_integration.py 0.00% <0.00%> (ø)
src/nectarchain/dqm/camera_monitoring.py 0.00% <0.00%> (ø)
src/nectarchain/dqm/mean_waveforms.py 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jlenain jlenain changed the title Fixing geometry DQM: Adding protections for runs with 21 masked pixels (due to shutter) Oct 20, 2023
@jlenain jlenain self-requested a review October 20, 2023 13:59
Copy link
Collaborator

@jlenain jlenain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @hashkar !
Thanks a lot !
I performed some tests on a few runs, all good on my side !

@jlenain jlenain merged commit 77dec94 into cta-observatory:master Oct 24, 2023
11 of 12 checks passed
@hashkar hashkar deleted the fixing_geometry branch October 27, 2023 10:59
@jlenain
Copy link
Collaborator

jlenain commented Dec 11, 2023

Was a follow-up of #63

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants