Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modification to WaveformContainer and ChargeContainer for SPE-WT #79

Merged
merged 3 commits into from
Oct 23, 2023

Conversation

sona-patel
Copy link
Contributor

This PR modifies the WaveformContainer and ChargeContainer (mainly load_wfs and write function) to read and store waveform given the list of event_id for splitting.

@jlenain jlenain self-requested a review October 17, 2023 20:25
@jlenain
Copy link
Collaborator

jlenain commented Oct 17, 2023

Thanks, @sona-patel !
Is this PR still in the draft stage ? The title seems to indicate so.

Copy link
Collaborator

@jlenain jlenain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, @sona-patel . I think the class behaviors should default to loading/writing whole runs. In such a case, default values should be provided in the loading/writing methods.

src/nectarchain/calibration/container/charge.py Outdated Show resolved Hide resolved
src/nectarchain/calibration/container/waveforms.py Outdated Show resolved Hide resolved
src/nectarchain/calibration/container/waveforms.py Outdated Show resolved Hide resolved
src/nectarchain/calibration/container/waveforms.py Outdated Show resolved Hide resolved
@sona-patel
Copy link
Contributor Author

Thanks, @sona-patel ! Is this PR still in the draft stage ? The title seems to indicate so.

Thanks for reviewing @jlenain!
Yes, I kept it as a draft, since I also want to add the user_scripts using this case. What do you suggest? Should I put it along with this PR or in a separate PR?

@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

Attention: 367 lines in your changes are missing coverage. Please review.

Comparison is base (39b677b) 5.61% compared to head (a468baf) 5.59%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##           master     #79      +/-   ##
=========================================
- Coverage    5.61%   5.59%   -0.03%     
=========================================
  Files          37      37              
  Lines        3667    3681      +14     
=========================================
  Hits          206     206              
- Misses       3461    3475      +14     
Files Coverage Δ
src/nectarchain/calibration/container/charge.py 0.00% <0.00%> (ø)
src/nectarchain/calibration/container/waveforms.py 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sona-patel sona-patel changed the title Draft: Modification to WaveformContainer and ChargeContainer for SPE-WT Modification to WaveformContainer and ChargeContainer for SPE-WT Oct 18, 2023
@jlenain jlenain merged commit 134fd99 into cta-observatory:master Oct 23, 2023
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants