-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modification to WaveformContainer
and ChargeContainer
for SPE-WT
#79
Conversation
Thanks, @sona-patel ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this, @sona-patel . I think the class behaviors should default to loading/writing whole runs. In such a case, default values should be provided in the loading/writing methods.
Thanks for reviewing @jlenain! |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #79 +/- ##
=========================================
- Coverage 5.61% 5.59% -0.03%
=========================================
Files 37 37
Lines 3667 3681 +14
=========================================
Hits 206 206
- Misses 3461 3475 +14
☔ View full report in Codecov by Sentry. |
WaveformContainer
and ChargeContainer
for SPE-WTWaveformContainer
and ChargeContainer
for SPE-WT
This PR modifies the
WaveformContainer
andChargeContainer
(mainlyload_wfs
andwrite
function) to read and store waveform given the list of event_id for splitting.