Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lint code #74

Merged
merged 13 commits into from
Oct 27, 2023
Merged

Lint code #74

merged 13 commits into from
Oct 27, 2023

Conversation

jlenain
Copy link
Collaborator

@jlenain jlenain commented Jul 28, 2023

This PR proposes to lint the entire repository (except user scripts), using the rules for black and flake8 defined in our pre-commit hooks (in .pre-commit-config.yaml), and introduced in #71.

At this moment, only nectarchain.calibration.container.charge_extractor is missing, as I would like to clarify a point in the __call__ method with @guillaumegrolleron beforehand.

@jlenain jlenain marked this pull request as draft July 28, 2023 13:59
@codecov
Copy link

codecov bot commented Jul 28, 2023

Codecov Report

Attention: 1873 lines in your changes are missing coverage. Please review.

Comparison is base (8e7be81) 6.62% compared to head (ccbf048) 7.35%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##           master     #74      +/-   ##
=========================================
+ Coverage    6.62%   7.35%   +0.72%     
=========================================
  Files          35      45      +10     
  Lines        3108    2978     -130     
=========================================
+ Hits          206     219      +13     
+ Misses       2902    2759     -143     
Files Coverage Δ
src/nectarchain/__init__.py 100.00% <100.00%> (ø)
src/nectarchain/dqm/__init__.py 100.00% <100.00%> (ø)
src/nectarchain/dqm/bokeh_app/app_hooks.py 82.85% <100.00%> (ø)
.../nectarchain/dqm/bokeh_app/tests/test_app_hooks.py 100.00% <100.00%> (ø)
src/nectarchain/dqm/tests/test_db_utils.py 100.00% <100.00%> (ø)
src/nectarchain/utils/stats.py 100.00% <100.00%> (ø)
src/nectarchain/display/__init__.py 0.00% <0.00%> (ø)
src/nectarchain/dqm/db_utils.py 36.00% <80.00%> (ø)
src/nectarchain/data/__init__.py 0.00% <0.00%> (ø)
...tarchain/makers/calibration/gain/utils/__init__.py 0.00% <0.00%> (ø)
... and 33 more

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jlenain jlenain marked this pull request as ready for review October 20, 2023 06:50
@jlenain
Copy link
Collaborator Author

jlenain commented Oct 20, 2023

I would like to propose to merge this PR now, and take care of the last few remaining lines of code to be cleaned with @guillaumegrolleron later in another PR. Lines which will in any case be changed by #78.

@jlenain jlenain removed the request for review from tibaldo October 26, 2023 13:20
@jlenain
Copy link
Collaborator Author

jlenain commented Oct 26, 2023

Resolved and merged conflicts introduced when PR #78 was merged into master.

@jlenain
Copy link
Collaborator Author

jlenain commented Oct 27, 2023

Many thanks for the reviews, @vmarandon !

@jlenain jlenain merged commit 12a5cc7 into cta-observatory:master Oct 27, 2023
11 of 12 checks passed
@jlenain jlenain deleted the clean branch October 27, 2023 17:14
@jlenain jlenain mentioned this pull request Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants