-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lint code #74
Lint code #74
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #74 +/- ##
=========================================
+ Coverage 6.62% 7.35% +0.72%
=========================================
Files 35 45 +10
Lines 3108 2978 -130
=========================================
+ Hits 206 219 +13
+ Misses 2902 2759 -143
☔ View full report in Codecov by Sentry. |
I would like to propose to merge this PR now, and take care of the last few remaining lines of code to be cleaned with @guillaumegrolleron later in another PR. Lines which will in any case be changed by #78. |
Resolved and merged conflicts introduced when PR #78 was merged into |
Many thanks for the reviews, @vmarandon ! |
This PR proposes to lint the entire repository (except user scripts), using the rules for
black
andflake8
defined in our pre-commit hooks (in.pre-commit-config.yaml
), and introduced in #71.At this moment, only
nectarchain.calibration.container.charge_extractor
is missing, as I would like to clarify a point in the__call__
method with @guillaumegrolleron beforehand.