Docstring, unit tests for nectarchain tools, component and containers #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
March 6, 2024 18:33
statement to not break the ctapipe logger
deleteting .tolist() action
-unit test implementation for the data.container module
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #114 +/- ##
==========================================
+ Coverage 28.54% 29.99% +1.44%
==========================================
Files 62 62
Lines 4102 4101 -1
==========================================
+ Hits 1171 1230 +59
+ Misses 2931 2871 -60 ☔ View full report in Codecov by Sentry. |
jlenain
reviewed
Mar 13, 2024
There was a problem hiding this comment.
Very nice, @guillaumegrolleron , thanks a lot !
The coverage nicely increased.
Let me know when this PR is ready for review.
jlenain
approved these changes
Mar 26, 2024
There was a problem hiding this comment.
Many thanks, @guillaumegrolleron . As already stated, I locally tested your branch, the coverage increased substantially and unit tests run smoothly locally.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, unit tests and documentation is implemented for the
containersmodule ofnectarchain.Modifications :
-bugfix :
diracimport does not break the logger anymore.-bugfix : access to
numpy.ndarrayfield withincontainers-improvement of event loop : speed up by a factor 2 + reduction of the ram needed by a factor 5 at least.
Next :
-Write unit tests and doc for the
toolsandcomponentsmodules