Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Take info on prescaler and trigger from previous subrun if not available in the current file #86

Merged
merged 10 commits into from
Feb 15, 2024

Conversation

aleberti
Copy link
Collaborator

Closes #85 .

Copy link

codecov bot commented Dec 22, 2023

Codecov Report

Attention: 35 lines in your changes are missing coverage. Please review.

Comparison is base (bff758a) 89.57% compared to head (dfd7fdb) 88.32%.
Report is 10 commits behind head on master.

❗ Current head dfd7fdb differs from pull request most recent head f336e9f. Consider uploading reports for the commit f336e9f to get more accurate results

Files Patch % Lines
ctapipe_io_magic/__init__.py 61.11% 35 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #86      +/-   ##
==========================================
- Coverage   89.57%   88.32%   -1.25%     
==========================================
  Files          10       10              
  Lines        1103     1165      +62     
==========================================
+ Hits          988     1029      +41     
- Misses        115      136      +21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

download_test_data.sh Outdated Show resolved Hide resolved
Copy link
Collaborator

@jsitarek jsitarek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fine as it is, but I left two comments for possible improvements.

@aleberti aleberti merged commit 3810a4b into master Feb 15, 2024
4 checks passed
@aleberti aleberti deleted the broken_subruns branch February 15, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

conversion of a MAGIC run to DL1 with a broken subrun
2 participants