Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gain_selection flag for flatfield and pedestal events #211

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Hckjs
Copy link

@Hckjs Hckjs commented Mar 1, 2024

closes #186

@Hckjs Hckjs requested a review from maxnoe March 1, 2024 09:33
Copy link

codecov bot commented Mar 1, 2024

Codecov Report

Attention: Patch coverage is 97.08738% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 90.75%. Comparing base (1285c6a) to head (29a40e8).

Files Patch % Lines
src/ctapipe_io_lst/calibration.py 91.66% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #211      +/-   ##
==========================================
+ Coverage   90.67%   90.75%   +0.08%     
==========================================
  Files          22       22              
  Lines        2498     2520      +22     
==========================================
+ Hits         2265     2287      +22     
  Misses        233      233              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

maxnoe
maxnoe previously approved these changes Mar 1, 2024
@maxnoe maxnoe self-requested a review March 5, 2024 16:30
@maxnoe maxnoe dismissed their stale review March 5, 2024 16:31

only looked at the last commit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add flag to set gain selection of calibration events
2 participants