Fix uncertainty calculation in StereoMeanCombiner #2658
+300
−84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxnoe
reviewed
Nov 22, 2024
| @@ -0,0 +1,145 @@ | |||
| """Helper functions for vectorizing numpy operations.""" | |||
|
|
|||
| import numpy as np | |||
There was a problem hiding this comment.
Do we really need a full new submodule for this? This looks like it could be in ctapipe/reco/telescope_event_handling or similar
There was a problem hiding this comment.
I think I put it in ctapipe.utils initially, but that module is already pretty large.
But putting it in ctapipe.reco would be fine with me. Alternatively, what about ctapipe.reco.utils?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a problem with the uncertainties calculated by
StereoMeanCombinerwhere the mapping of telescope events to array events did not work correctly. This resulted in many nan values in e.g. theRandomForestRegressor_energy_uncertcolumn.In doing so, I added a new module (
ctapipe.vectorization) for the helper functions I implemented. This module also contains a faster (numba) alternative tonp.unique,ctapipe.vectorization.get_subarray_index.This is part of #2497, but I think this should be fixed regardless of the other content of that PR.