@import linter for bundlers
#1083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…my-marmoset-dcd64d6c43
…my-marmoset-dcd64d6c43
…my-marmoset-dcd64d6c43
This comment was marked as resolved.
This comment was marked as resolved.
…my-marmoset-dcd64d6c43
Comment on lines
+115
to
+116
| const url = new URL(uri, 'https://454c178c-dadf-429e-8d9c-88e032826008.com'); | ||
| if (url.host && url.host !== '454c178c-dadf-429e-8d9c-88e032826008.com') { |
There was a problem hiding this comment.
Why this domain? Clever though!
There was a problem hiding this comment.
I wanted something that is extremely unlikely to be used in a real url and generating a new uuid is easy :)
I really which there was some builtin API to detect if a given string is a full url or only a relative path.
Antonio-Laguna
approved these changes
Sep 5, 2023
romainmenke
deleted the
at-import-linter-for-bundlers--impartial-pygmy-marmoset-dcd64d6c43
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This covers the main issues authors can encounter when bundling CSS :
https://) and local importsWe might add some more later, but I think this is already a good base set of issues it can detect.