[WIP] Babel plugin for preprocessing #757

kof · 2018-07-14T09:26:58Z

Issue #579

- custom identifiers - rule ref - null/undefined as styles - property identifier - numeric values

HenriBeck · 2018-07-14T16:17:39Z

packages/babel-plugin/src/index.js

+const defaultIdentifiers = ['createStyleSheet', 'injectSheet']
+
+export default declare(({types: t, ...api}, {identifiers = defaultIdentifiers, jssOptions}) => {
+  api.assertVersion(7)


Should we maybe update our own babel packages to v7 as well? Would make testing easier.

sure, if you get time, v6 and 7 are largely compatible

styles returned from a function returned from a function call with refs

kof · 2018-07-20T19:40:57Z

@cssinjs/core anyone wants to review this one? I am in the testing phase yet, but I want already start with making this code high quality readable

HenriBeck · 2018-07-21T02:10:31Z

Can you rename the directory from babel-plugin to babel-plugin-jss?

HenriBeck · 2018-07-21T02:13:54Z

packages/babel-plugin/src/testUtils.js

@@ -0,0 +1,14 @@
+import * as babel7 from '@babel/core'


Maybe rename to just babel?

I am working on tests to ensure babel6 works, so it will be needed

HenriBeck · 2018-07-21T02:23:29Z

Also, can we have one standard for where the test files should be located? Because right now sometimes *.test.js is used and sometimes all of the tests are inside a tests folder.

kof · 2018-07-21T08:30:55Z

Can you rename the directory from babel-plugin to babel-plugin-jss?

yep

kof · 2018-07-21T08:34:46Z

Also, can we have one standard for where the test files should be located? Because right now sometimes *.test.js is used and sometimes all of the tests are inside a tests folder.

There are 2 different testing scenarios. One is unit tests, where I actually test a specific module. The other one is more like an integration tests. In this case I 100% did integration tests and I had them all in index.test.js but then the amount of tests grew and file became unreadable, so I split them up in separate suits.

I think its ok to not have this consistency. If you are testing a specific module, then it should be module.test.js, otherwise if a test uses multiple modules it should go into __tests__. Both patterns are supported by jest by default without changing the config.

kof · 2018-07-27T13:05:14Z

Remaining todo:

find a way to identify function calls without relying on a name, because this doesn't work after certain babel plugins, it be something.default()
find a way to extract imported static variables
evaluate module code in a separate context instead of eval
add tests ensuring the proper variable scoping when evaluating (use same variable name to detect wrong scoping)
use evaluation more instead of nodes traversing, seems like a more robust appraoch
test on production code bases

HenriBeck · 2018-08-06T19:41:27Z

packages/babel-plugin-jss/package.json

+    "@babel/helper-plugin-utils": "^7.0.0-beta.53",
+    "babel-generator": "^6.26.1",
+    "babel-types": "^6.26.0",
+    "jss": "^9.8.7",


Shouldn't jss be a peer dependency?

seems valid

jahglow · 2019-03-22T10:04:40Z

guys, any progress on this? Like css extraction I mean...

kof added 5 commits July 13, 2018 16:33

wip static extraction

c69cc65

wip 2

4b14534

- custom identifiers - rule ref - null/undefined as styles - property identifier - numeric values

support arrays

84e06b9

pass options with classes

647d516

cleanup

88e44be

kof self-assigned this Jul 14, 2018

kof added 2 commits July 14, 2018 11:46

Merge branch 'master' into babel-plugin

bf7cb4b

accept classes as a sheet option, add @raw rule

36416cc

HenriBeck reviewed Jul 14, 2018

View reviewed changes

kof added 21 commits July 15, 2018 01:04

resolve styles ref

4e32d0b

add a bench

c806d3f

multiple calls

cee5c1e

use t.isFunction

7f2d9cb

resolve nested refs in styles

59c6a37

extend options literal

6ea018a

support options ref

2a0cca8

add classes option to the ref in place

6a9202b

test for unresolvable ref

42d36aa

extend imported options ref

3e2c49d

support styles creator function

b7b4bda

support fn ref

0c815ec

support theme arg access over config

94696e9

Better error handling for theme props access

0379c3a

resolve property access

7866f5e

bail out on property access from imports

9c83915

partially bailn out when accessing imported

34b35c9

cleanup upcomming tests

fdce064

added decorators test

92ac7cb

rewrite identifiers configuration with package name

93d515b

check for imported package name

afd3bc8

kof added 11 commits July 20, 2018 14:01

binary expressions with refs

0e28bf7

inline docs

1f0e3bb

binary expression with a function call

47815e8

styles returned from a function expression call

ecdf5f1

styles returned from a function expression call with arguments

47ececc

styles returned from a function expression call with ref arguments

c928a38

use snapshots

7c82d5b

styles value returned from a function call

751a599

styles returned from a function returned from a function call with refs

extract functions into separate modules

7fd0709

move all fns into utils dir

972352a

split up the tests

8ddfd11

move default identifiers

26984c9

HenriBeck reviewed Jul 21, 2018

View reviewed changes

kof added 5 commits July 21, 2018 10:36

rename the directory

71ec732

add babel6, move testUtils to __tests__

8454a56

add tests for babel 6

52ca753

ignore callee without a name

33bb4c8

string as a package name identifier

6b17215

HenriBeck reviewed Aug 6, 2018

View reviewed changes

kof force-pushed the master branch from 733e70b to d90c2d5 Compare January 17, 2019 01:41

kof force-pushed the master branch from 854678c to 2912127 Compare September 22, 2019 16:34

kof force-pushed the master branch from c982bda to 9f7599a Compare September 30, 2019 14:59

kof closed this Dec 31, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[WIP] Babel plugin for preprocessing #757

[WIP] Babel plugin for preprocessing #757

kof commented Jul 14, 2018 •

edited

Loading

HenriBeck Jul 14, 2018

kof Jul 14, 2018

kof commented Jul 20, 2018

HenriBeck commented Jul 21, 2018

HenriBeck Jul 21, 2018

kof Jul 21, 2018

HenriBeck commented Jul 21, 2018

kof commented Jul 21, 2018

kof commented Jul 21, 2018 •

edited

Loading

kof commented Jul 27, 2018 •

edited

Loading

HenriBeck Aug 6, 2018

kof Aug 6, 2018

jahglow commented Mar 22, 2019

[WIP] Babel plugin for preprocessing #757

[WIP] Babel plugin for preprocessing #757

Conversation

kof commented Jul 14, 2018 • edited Loading

HenriBeck Jul 14, 2018

Choose a reason for hiding this comment

kof Jul 14, 2018

Choose a reason for hiding this comment

kof commented Jul 20, 2018

HenriBeck commented Jul 21, 2018

HenriBeck Jul 21, 2018

Choose a reason for hiding this comment

kof Jul 21, 2018

Choose a reason for hiding this comment

HenriBeck commented Jul 21, 2018

kof commented Jul 21, 2018

kof commented Jul 21, 2018 • edited Loading

kof commented Jul 27, 2018 • edited Loading

HenriBeck Aug 6, 2018

Choose a reason for hiding this comment

kof Aug 6, 2018

Choose a reason for hiding this comment

jahglow commented Mar 22, 2019

kof commented Jul 14, 2018 •

edited

Loading

kof commented Jul 21, 2018 •

edited

Loading

kof commented Jul 27, 2018 •

edited

Loading