Trying to reach code coverage 100 % again #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
|
oxisto
force-pushed
the
trying-100-again
branch
from
2497859
to
adb0153
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR finally lifts us to 100 % 🚀 by adding the remaining test cases.
It also includes a workaround to fix an incorrect code coverage XML produced by Kover and incorrectly parsed by codecov. Basically Kover produced coverage information on a line that had neither covered nor uncovered instructions. While Kover's HTML report says this is "ok", codecov classifies it as a miss. In reality, the line in the XML should not be there at all.
I have added issues to both projects, to hopefully fix this issue: