Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Two level timeout for windows codepath #43

Merged
merged 1 commit into from
May 27, 2020
Merged

Two level timeout for windows codepath #43

merged 1 commit into from
May 27, 2020

Conversation

H0bo
Copy link
Contributor

@H0bo H0bo commented May 26, 2020 •
edited
Loading

Discussion in #37

@cs01
Copy link
Owner

cs01 commented May 26, 2020 •
edited
Loading

Thanks! LGTM but for some reason I don't see the travis tests. I would like to have them before merging. Not sure what's going on there, I'll have to look into it later. (If you or anyone else knows, feel free to chime in)

@H0bo
Copy link
Contributor Author

H0bo commented May 27, 2020 •
edited
Loading

It's here but the docs failed. I think it's caused by this change in mkdocs, which breaks mkdocstrings. Though it should've been fixed since mkdocstrings version 0.8.0, see this commit.

@cs01
Copy link
Owner

cs01 commented May 27, 2020

In that case, I'll merge this as is and work on the doc updates later. Thanks for the PR.

@cs01 cs01 merged commit 3c8c92e into cs01:master May 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@H0bo @cs01