Skip to content

Commit

Permalink
show gdbgui version in more places (#401)
Browse files Browse the repository at this point in the history
  • Loading branch information
cs01 authored Aug 29, 2021
1 parent 0e636d5 commit d800c7d
Show file tree
Hide file tree
Showing 6 changed files with 22 additions and 9 deletions.
6 changes: 5 additions & 1 deletion .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,11 @@
<!-- add an 'x' in the brackets below -->
- [] I have added an entry to `docs/changelog.md`
- [] I have added an entry to `CHANGELOG.md`, or an entry is not needed for this change

## Summary of changes
<!--
* fixed bug
* added new feature
-->

## Test plan
<!-- provide evidence of testing, preferably with command(s) that can be copy+pasted by others -->
Expand Down
7 changes: 4 additions & 3 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,14 @@

## 0.15.0.0

No new features, just bugfixes and compatibility fixes
This release is focused mostly on Python 3.9 compatibility and updating dependencies

- Support only Python 3.9 (though other Python versions may work)
- Support only Python 3.9 (though other Python versions may still work)
- Use only the threading async model for flask-socketio. No longer support gevent or eventlet.
- [bugfix] Catch exception if gdb used in tty window crashes instead of gdbgui crashing along with it
- Disable pagination in gdb ttyy by default. It can be turned back on with `set pagination off`.
- Disable pagination in gdb tty by default. It can be turned back on with `set pagination off`.
- Upgrade various dependencies for both the backend and frontend (Python and JavaScript)
- Display gdbgui version in "about" and "session information"

## 0.14.0.2

Expand Down
2 changes: 1 addition & 1 deletion MANIFEST.in
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ prune docker
prune images
prune gdbgui/__pycache__
prune gdbgui/server/__pycache__
prune gdbgui/src/
prune gdbgui/src

exclude mypy.ini
exclude .eslintrc.json
Expand Down
2 changes: 1 addition & 1 deletion gdbgui/server/app.py
Original file line number Diff line number Diff line change
Expand Up @@ -260,7 +260,7 @@ def read_and_forward_gdb_and_pty_output():
pass

except Exception:
logger.error(traceback.format_exc())
logger.error("caught exception, continuing:" + traceback.format_exc())

debug_sessions_to_remove += check_and_forward_pty_output()
for debug_session in set(debug_sessions_to_remove):
Expand Down
2 changes: 1 addition & 1 deletion gdbgui/src/js/InitialStoreData.ts
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ const initial_store_data = {
// @ts-expect-error ts-migrate(2304) FIXME: Cannot find name 'initial_data'.
gdbgui_version: initial_data.gdbgui_version,
latest_gdbgui_version: "(not fetched)",
gdb_version: undefined, // this is parsed from gdb's output
gdb_version: "unknown", // this is parsed from gdb's output
gdb_version_array: [], // this is parsed from gdb's output
gdb_pid: undefined,
// @ts-expect-error ts-migrate(2304) FIXME: Cannot find name 'initial_data'.
Expand Down
12 changes: 10 additions & 2 deletions gdbgui/src/js/TopBar.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,13 @@ let About = {
show_about: function() {
Actions.show_modal(
"About gdbgui",
<React.Fragment>Copyright © Chad Smith, chadsmith.dev</React.Fragment>
<div>
<div>gdbgui, v{store.get("gdbgui_version")}</div>
<div>Copyright © Chad Smith</div>
<div>
<a href="https://chadsmith.dev">chadsmith.dev</a>
</div>
</div>
);
}
};
Expand All @@ -59,10 +65,12 @@ let show_session_info = function() {
<tr>
<td>gdb version: {store.get("gdb_version")}</td>
</tr>

<tr>
<td>gdb pid for this tab: {store.get("gdb_pid")}</td>
</tr>
<tr>
<td>gdbgui v{store.get("gdbgui_version")}</td>
</tr>
</tbody>
</table>
</React.Fragment>
Expand Down

0 comments on commit d800c7d

Please sign in to comment.