Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use page_title for book page #524

Merged

Conversation

straight-shoota
Copy link
Member

The page_title property is already used in other places (for example the install layout).
It allows using a different title on the page itself, in contrast to other places where title refers to the page. For the book page, we want the external title to be Crystal Programming (that's the name of the book), but the book page itself has a longer title.

Copy link

netlify bot commented Nov 17, 2023

Deploy Preview for crystal-website ready!

Name Link
🔨 Latest commit 5e9cf80
🔍 Latest deploy log https://app.netlify.com/sites/crystal-website/deploys/6557ec8b18709e00081efce1
😎 Deploy Preview https://deploy-preview-524--crystal-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@straight-shoota straight-shoota merged commit 83c0c52 into crystal-lang:relaunch-2023 Nov 22, 2023
5 checks passed
@straight-shoota straight-shoota deleted the fix/page_title branch November 22, 2023 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants