Skip to content

Commit

Permalink
Fmt + fix tensor min
Browse files Browse the repository at this point in the history
  • Loading branch information
christopherzimmerman committed Jun 6, 2024
1 parent 750a6ee commit 57389fb
Show file tree
Hide file tree
Showing 2 changed files with 41 additions and 1 deletion.
40 changes: 40 additions & 0 deletions spec/tensor/reduction_spec.cr
Original file line number Diff line number Diff line change
@@ -0,0 +1,40 @@
# Copyright (c) 2023 Crystal Data Contributors
#
# MIT License
#
# Permission is hereby granted, free of charge, to any person obtaining
# a copy of this software and associated documentation files (the
# "Software"), to deal in the Software without restriction, including
# without limitation the rights to use, copy, modify, merge, publish,
# distribute, sublicense, and/or sell copies of the Software, and to
# permit persons to whom the Software is furnished to do so, subject to
# the following conditions:
#
# The above copyright notice and this permission notice shall be
# included in all copies or substantial portions of the Software.
#
# THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
# EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
# MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
# NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE
# LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION
# OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION
# WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.

require "../spec_helper"

describe Tensor do
it "can reduce a tensor's min along an axis" do
input = [[-1, 1], [-1, 1]].to_tensor
expected = [-1, -1].to_tensor

Num::Testing.tensor_equal(input.min(1), expected).should be_true
end

it "can reduce a tensor's min to a scalar" do
input = [[-2, 1], [-1, 1]].to_tensor
expected = -2

(input.min == expected).should be_true
end
end
2 changes: 1 addition & 1 deletion src/tensor/reduction.cr
Original file line number Diff line number Diff line change
Expand Up @@ -239,7 +239,7 @@ class Tensor(T, S)
# Num.min(a) # => 3
# ```
def min : T
Num.min(self, axis, dims)
Num.min(self)
end

# Reduces a `Tensor` along an axis, finding the min of each
Expand Down

0 comments on commit 57389fb

Please sign in to comment.