-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rootless + smaller image + cleanup #402
Open
chevdor
wants to merge
15
commits into
cryptosharks131:v1.10.0
Choose a base branch
from
chevdor:wk-241119-rootless
base: v1.10.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chevdor
force-pushed
the
wk-241119-rootless
branch
from
November 19, 2024 10:37
9eb0bf6
to
633c4b2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR looks bigger than it is, due to the removal of leading spaces...
Here are the changes:
container
subfolderjustfile
, it is convenient for those using it, inert for others. It provides also a nice doc and shows how to build the images. See below.justfile
Users not using
just
can just ignore.For others, you need to set your
IMAGE=...
in the.env
file. It will typically look likeIMAGE=your_name/lndg
.Alternatively, you may provide your own registry:
IMAGE=docker.io/chevdor/lndg
.After that, you may just 😄 run:
just build_image
andjust push_image
.WARNING: Change for Docker users lndg is now in
/lndg/
and no longer/app
.