Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tags to channels #314

Draft
wants to merge 41 commits into
base: v1.9.0
Choose a base branch
from

Conversation

proof-of-reality
Copy link
Contributor

@proof-of-reality proof-of-reality commented Aug 2, 2023

This will allow users to manage channels in a bulk

*Nice to have for future versions:

  • Color for each group/tag
  • Switch channel groups based on routing/liquidity events

Features/rules added with this:

  • LNDg default settings works like the "parent default" settings
  • When adding channel A from LNDg group to a new group G, channel A is removed from group LNDg
  • When adding the same channel A to a new group H, A will belong to group G and H simultaneously
  • When removing channel A from group H and G, A will return to LNDg
  1. Groups can be partially configurable:
    1.1. It's allowed to create a group for AR and another for AF
    1.2. It's allowed to split AR or AF into further more groups with the condition of: channel A cannot be in group G and H if both groups have a single setting in common. Say: G->AR-Time:5 and H->AR-Time:2 (except Enabled settings)
    1.3. In contrast to 1.2 if you add some channels to a rebalancer group G but do NOT assign any rebalance settings to it, the rebalancer will act as if none of these channels were assigned to the newly created group and will get AR settings from LNDg instead. (The rebalance would get triggered with the LNDg default settings)
    1.4. GUI/LND settings and AR-Workers are owned by LNDg group. (can be changed in the future)

Summary: Any group settings can be split into multiple groups if and only if channels within those same groups doesnt share any common setting

@proof-of-reality proof-of-reality marked this pull request as draft August 2, 2023 23:36
gui/views.py Outdated Show resolved Hide resolved
@proof-of-reality proof-of-reality marked this pull request as ready for review August 7, 2023 18:34
@proof-of-reality proof-of-reality marked this pull request as draft August 7, 2023 22:07
@proof-of-reality proof-of-reality marked this pull request as ready for review August 13, 2023 17:13
@proof-of-reality proof-of-reality marked this pull request as draft October 23, 2023 14:43
@cryptosharks131 cryptosharks131 changed the base branch from v1.8.0 to v1.9.0 March 2, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant